-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add release-please automation #2431
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
+ Coverage 92.70% 92.72% +0.02%
==========================================
Files 137 137
Lines 4993 4993
Branches 1056 1056
==========================================
+ Hits 4629 4630 +1
+ Misses 364 363 -1
|
@@ -0,0 +1,33 @@ | |||
{ | |||
"bootstrap-sha": "0ef1fc28d366b74d98b73b5d6334ffdc75342fe2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where comes this SHA from?
if it is intended that someone else the you releases a readme/doc would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the sha for the last manual release. It is used by release-please to know when the automated history starts and the manual release history ends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This replaces #2393 which was created on a branch name that broke the automation 😨
Due to branch protection rules, we cannot create the release PRs automatically on this repo with a github action, but they need to be created by running release-please from the command line. It is still fully automated, it just creates the PR from the maintainer's fork and under their username so the CLA bot is happy.I modified the action so that it will create release PRs using my user from a fork.