Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release-please automation #2431

Merged
merged 7 commits into from
Aug 30, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 26, 2021

This replaces #2393 which was created on a branch name that broke the automation 😨

Due to branch protection rules, we cannot create the release PRs automatically on this repo with a github action, but they need to be created by running release-please from the command line. It is still fully automated, it just creates the PR from the maintainer's fork and under their username so the CLA bot is happy.

I modified the action so that it will create release PRs using my user from a fork.

@dyladan dyladan requested a review from a team August 26, 2021 20:14
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #2431 (5c2f805) into main (7d2c4aa) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5c2f805 differs from pull request most recent head 2aaeabd. Consider uploading reports for the commit 2aaeabd to get more accurate results

@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
+ Coverage   92.70%   92.72%   +0.02%     
==========================================
  Files         137      137              
  Lines        4993     4993              
  Branches     1056     1056              
==========================================
+ Hits         4629     4630       +1     
+ Misses        364      363       -1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@vmarchaud vmarchaud requested a review from a team August 29, 2021 17:32
@@ -0,0 +1,33 @@
{
"bootstrap-sha": "0ef1fc28d366b74d98b73b5d6334ffdc75342fe2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where comes this SHA from?
if it is intended that someone else the you releases a readme/doc would be nice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sha for the last manual release. It is used by release-please to know when the automated history starts and the manual release history ends.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants