-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: hoist dependencies to speed up ci #2416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
+ Coverage 92.62% 92.66% +0.04%
==========================================
Files 137 137
Lines 4975 4975
Branches 1048 1048
==========================================
+ Hits 4608 4610 +2
+ Misses 367 365 -2
|
This reverts commit dc55c90.
blumamir
reviewed
Aug 17, 2021
naseemkullah
approved these changes
Aug 17, 2021
blumamir
approved these changes
Aug 17, 2021
johnbley
approved these changes
Aug 17, 2021
obecny
approved these changes
Aug 17, 2021
I have seen following warning in CI runs:
In special the first few indicated that backcompat tests might be useless now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what @blumamir did in contrib
Also update dependencies which didn't match the hoisted versions in order to speed up the hoist.
Tests now run in under 5 minutes in CI with a cache miss