Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples opentelemetry-api version fix #2358

Merged
merged 5 commits into from
Jul 21, 2021

Conversation

CptSchnitz
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • added opentelemetry-api to examples that were missing it.
  • upgraded opentelemetry-api version to 1.0.1 on all of the examples
  • fixed commands in collector-example-node readme

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #2358 (21763ba) into main (cb06b78) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   92.79%   92.77%   -0.02%     
==========================================
  Files         145      145              
  Lines        5221     5221              
  Branches     1070     1070              
==========================================
- Hits         4845     4844       -1     
- Misses        376      377       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan dyladan merged commit 39c6ea5 into open-telemetry:main Jul 21, 2021
@CptSchnitz CptSchnitz deleted the issue-2346 branch July 22, 2021 08:01
@dyladan dyladan added the document Documentation-related label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants