-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: headers are appended to existing one (open-telemetry#2335) #2357
fix: headers are appended to existing one (open-telemetry#2335) #2357
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2357 +/- ##
==========================================
+ Coverage 92.47% 92.77% +0.30%
==========================================
Files 122 145 +23
Lines 4132 5221 +1089
Branches 859 1070 +211
==========================================
+ Hits 3821 4844 +1023
- Misses 311 377 +66
|
packages/opentelemetry-exporter-collector/test/browser/util.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/test/browser/util.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/browser/util.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one last thing, other than that lgtm
packages/opentelemetry-exporter-collector/test/browser/util.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and neat :), lgtm thx for changes
Once the lint is fixed this is mergeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again to try to fix github
Which problem is this PR solving?
Short description of the changes
util.test.ts
underpackages/opentelemetry-exporter-collector/test/browser/util.test.ts
which exercises the sendWithXhr method of
packages/opentelemetry-exporter-collector/src/platform/browser/util.ts
CollectorTraceExporter
api has set explicit Content-Type and Accept Headers . If that is not the case , only then the sendWithXhrt method applies the Content-Type and Accept Headers with the value application/json.