Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default HTTP exporter port to 55681 #2331

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

NathanielRN
Copy link
Contributor

Which problem is this PR solving?

Fixes: #2330

Short description of the changes

  • Changes default HTTP exporter port to be 55681 instead of 4317 because 4317 is reserved for gRPC in the specs
  • 55681 is used by opentelemetry-collector so it should be a good choice

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #2331 (4639c09) into main (6e82726) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2331   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         145      145           
  Lines        5216     5216           
  Branches     1068     1068           
=======================================
  Hits         4839     4839           
  Misses        377      377           

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmarchaud vmarchaud added the bug Something isn't working label Jul 11, 2021
@NathanielRN NathanielRN force-pushed the change-default-http-port branch from f67717c to 4639c09 Compare July 12, 2021 16:18
@NathanielRN NathanielRN requested a review from vmarchaud July 12, 2021 16:19
@dyladan dyladan merged commit 68454a4 into open-telemetry:main Jul 14, 2021
@NathanielRN NathanielRN deleted the change-default-http-port branch August 3, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP HTTP Exporter Should Not Use the GRPC Port
5 participants