-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default HTTP exporter port to 55681 #2331
Merged
dyladan
merged 2 commits into
open-telemetry:main
from
NathanielRN:change-default-http-port
Jul 14, 2021
Merged
Change default HTTP exporter port to 55681 #2331
dyladan
merged 2 commits into
open-telemetry:main
from
NathanielRN:change-default-http-port
Jul 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
July 7, 2021 06:22
NathanielRN
force-pushed
the
change-default-http-port
branch
from
July 7, 2021 06:23
27fd363
to
f67717c
Compare
willarmiros
approved these changes
Jul 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #2331 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 145 145
Lines 5216 5216
Branches 1068 1068
=======================================
Hits 4839 4839
Misses 377 377 |
vmarchaud
reviewed
Jul 11, 2021
vmarchaud
reviewed
Jul 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you'll also need to change the default there:
NathanielRN
force-pushed
the
change-default-http-port
branch
from
July 12, 2021 16:18
f67717c
to
4639c09
Compare
vmarchaud
approved these changes
Jul 12, 2021
MSNev
approved these changes
Jul 12, 2021
dyladan
approved these changes
Jul 14, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes: #2330
Short description of the changes
55681
instead of4317
because4317
is reserved for gRPC in the specs55681
is used byopentelemetry-collector
so it should be a good choice