Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin config options #229

Merged
merged 5 commits into from
Sep 10, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • This is based on OPTION 1 mentioned in the Proposal: Plugin configuration options #214.

  • Per SIG, OPTION 1 is more superior because it allows individual config.

  • Note (per this implementation): only the individual config will get passed to the respective plugin.

@mayurkale22
Copy link
Member Author

/cc @OlivierAlbertini Please review.

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #229 into master will decrease coverage by 0.02%.
The diff coverage is 95.34%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   98.94%   98.91%   -0.03%     
==========================================
  Files          67       67              
  Lines        2645     2495     -150     
  Branches      173      155      -18     
==========================================
- Hits         2617     2468     -149     
+ Misses         28       27       -1
Impacted Files Coverage Δ
...metry-core/src/trace/instrumentation/BasePlugin.ts 11.11% <0%> (-1.39%) ⬇️
...ry-node-tracer/src/instrumentation/PluginLoader.ts 92.3% <100%> (+2.3%) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <100%> (ø) ⬆️
...telemetry-core/src/context/propagation/B3Format.ts 94.59% <0%> (-3.24%) ⬇️
...core/src/context/propagation/BinaryTraceContext.ts 96.15% <0%> (-2.21%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
...s/opentelemetry-core/test/trace/tracestate.test.ts 100% <0%> (ø) ⬆️
...entelemetry-core/test/common/ConsoleLogger.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
... and 16 more

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could close #210 as well

@mayurkale22 mayurkale22 force-pushed the plugin_config branch 2 times, most recently from 036a62a to 045e048 Compare September 9, 2019 17:03
@mayurkale22 mayurkale22 merged commit 8279133 into open-telemetry:master Sep 10, 2019
@mayurkale22 mayurkale22 deleted the plugin_config branch September 10, 2019 20:56
@mayurkale22 mayurkale22 mentioned this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Plugin configuration options
6 participants