-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin config options #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
danielkhan,
iredelmeier and
rochdev
as code owners
August 28, 2019 22:48
mayurkale22
commented
Aug 28, 2019
packages/opentelemetry-types/src/trace/instrumentation/Plugin.ts
Outdated
Show resolved
Hide resolved
mayurkale22
commented
Aug 28, 2019
packages/opentelemetry-types/src/trace/instrumentation/Plugin.ts
Outdated
Show resolved
Hide resolved
/cc @OlivierAlbertini Please review. |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 98.94% 98.91% -0.03%
==========================================
Files 67 67
Lines 2645 2495 -150
Branches 173 155 -18
==========================================
- Hits 2617 2468 -149
+ Misses 28 27 -1
|
OlivierAlbertini
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could close #210 as well
markwolff
approved these changes
Aug 28, 2019
vmarchaud
approved these changes
Aug 29, 2019
packages/opentelemetry-types/src/trace/instrumentation/Plugin.ts
Outdated
Show resolved
Hide resolved
draffensperger
approved these changes
Sep 9, 2019
packages/opentelemetry-types/src/trace/instrumentation/Plugin.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-types/src/trace/instrumentation/Plugin.ts
Outdated
Show resolved
Hide resolved
mayurkale22
force-pushed
the
plugin_config
branch
2 times, most recently
from
September 9, 2019 17:03
036a62a
to
045e048
Compare
mayurkale22
force-pushed
the
plugin_config
branch
from
September 10, 2019 16:47
045e048
to
498be8f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
This is based on OPTION 1 mentioned in the Proposal: Plugin configuration options #214.
Per SIG, OPTION 1 is more superior because it allows individual config.
Note (per this implementation): only the individual config will get passed to the respective plugin.