-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module opentelemetry/instrumentation-grpc required #2283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor README.md update. It looks like we also need module @opentelemetry/instrumentation-grpc, otherwise we are getting module not found error. % node -r ./tracing.js app.js internal/modules/cjs/loader.js:888 throw err; ^ Error: Cannot find module '@opentelemetry/instrumentation-grpc' Require stack: - /tracing.js - internal/preload at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15) at Function.Module._load (internal/modules/cjs/loader.js:730:27) at Module.require (internal/modules/cjs/loader.js:957:19) at require (internal/modules/cjs/helpers.js:88:18) at Object.<anonymous> (/Users/ps105769/POC/open_tel/tracing.js:7:33) at Module._compile (internal/modules/cjs/loader.js:1068:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10) at Module.load (internal/modules/cjs/loader.js:933:32) at Function.Module._load (internal/modules/cjs/loader.js:774:14) at Module.require (internal/modules/cjs/loader.js:957:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/tracing.js', 'internal/preload' ] }
pramodsreek
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
June 15, 2021 13:25
|
dyladan
approved these changes
Jun 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
+ Coverage 92.68% 92.70% +0.01%
==========================================
Files 145 145
Lines 5184 5184
Branches 1060 1060
==========================================
+ Hits 4805 4806 +1
+ Misses 379 378 -1
|
MSNev
approved these changes
Jun 16, 2021
vmarchaud
approved these changes
Jun 17, 2021
obecny
approved these changes
Jun 21, 2021
Merged
This was referenced Feb 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor README.md update. It looks like we also need module @opentelemetry/instrumentation-grpc, otherwise we are getting module not found error.
% node -r ./tracing.js app.js
internal/modules/cjs/loader.js:888
throw err;
^
Error: Cannot find module '@opentelemetry/instrumentation-grpc'
Require stack:
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
at Function.Module._load (internal/modules/cjs/loader.js:730:27)
at Module.require (internal/modules/cjs/loader.js:957:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Object. (/tracing.js:7:33)
at Module._compile (internal/modules/cjs/loader.js:1068:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
at Module.load (internal/modules/cjs/loader.js:933:32)
at Function.Module._load (internal/modules/cjs/loader.js:774:14)
at Module.require (internal/modules/cjs/loader.js:957:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [ '/tracing.js', 'internal/preload' ]
}
Which problem is this PR solving?
Short description of the changes