chore: downgrade karma-webpack #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOS the most recent version of karma-webpack is broken
dyladan
requested review from
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2234 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 143 143
Lines 5154 5154
Branches 1060 1060
=======================================
Hits 4754 4754
Misses 400 400 |
vmarchaud
approved these changes
May 26, 2021
|
@obecny lmk if this works for you or if you have an objection to the downgrade |
I have already downgraded this on contrib but it was upgraded later too. I'm happy to keep ver 4. as then can debug locally easier |
obecny
approved these changes
May 26, 2021
|
Added to renovate ignore so it won't be automatically upgraded again |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS the most recent version of karma-webpack is broken
Fixes #2231