-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrading to api ver. 0.20.0 #2225
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
- Coverage 92.72% 92.28% -0.44%
==========================================
Files 142 142
Lines 5124 5146 +22
Branches 1050 1062 +12
==========================================
- Hits 4751 4749 -2
- Misses 373 397 +24
|
Thanks this looks like it was quite a bit of work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goods to me
@@ -29,7 +29,7 @@ import { TimedEvent } from '../TimedEvent'; | |||
export interface ReadableSpan { | |||
readonly name: string; | |||
readonly kind: SpanKind; | |||
readonly spanContext: SpanContext; | |||
readonly spanContext: () => SpanContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly spanContext: () => SpanContext; | |
spanContext(): SpanContext; |
I find this more readable and it is in sync with the API Span interface
propagation, | ||
setSpan, | ||
getSpan, | ||
propagation, trace, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems some lint setting has change recently. Same on a few other places.
I don't care much about this so feel free to keep.
Ignore Tracer.ts -> startActiveSpan, I just took it from api, but once this PR is reviewed and merged ->
#2221
It will supersede the one I added (copy paste from api)