Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GTS and prettier #2204

Merged
merged 10 commits into from
May 19, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ jobs:
metapackages/*/package-lock.json
packages/*/package-lock.json
integration-tests/*/package-lock.json
key: ${{ runner.os }}-lint-${{ hashFiles('**/package.json') }}
# increment the trailing number to break the cache manually
key: ${{ runner.os }}-lint-${{ hashFiles('**/package.json') }}-0

# On a cache hit, use ci to speed up the install process
- name: Bootstrap (cache hit)
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-core/src/common/time.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function numberToHrtime(epochMillis: number): api.HrTime {
function getTimeOrigin(): number {
let timeOrigin = performance.timeOrigin;
if (typeof timeOrigin !== 'number') {
const perf: TimeOriginLegacy = (performance as unknown) as TimeOriginLegacy;
const perf: TimeOriginLegacy = performance as unknown as TimeOriginLegacy;
timeOrigin = perf.timing && perf.timing.fetchStart;
}
return timeOrigin;
Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry-core/test/utils/environment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function mockEnvironment(values: RAW_ENVIRONMENT) {
});
} else {
Object.keys(values).forEach(key => {
((window as unknown) as RAW_ENVIRONMENT)[key] = String(values[key]);
(window as unknown as RAW_ENVIRONMENT)[key] = String(values[key]);
});
}
}
Expand All @@ -53,7 +53,7 @@ export function removeMockEnvironment() {
});
} else {
Object.keys(lastMock).forEach(key => {
delete ((window as unknown) as RAW_ENVIRONMENT)[key];
delete (window as unknown as RAW_ENVIRONMENT)[key];
});
}
lastMock = {};
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-core/test/utils/wrap.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function makeWrapped(
defineProperty(wrapper, '__wrapped', wrapped);
defineProperty(wrapper, '__unwrap', unwrap);
defineProperty(wrapper, '__original', original);
return (wrapper as unknown) as ShimWrapped;
return wrapper as unknown as ShimWrapped;
}

function defineProperty(obj: any, name: string, value: unknown) {
Expand Down