Skip to content

feat: add forceFlush-function to the BasicTracerProvider-class#2191

Merged
vmarchaud merged 9 commits into
open-telemetry:mainfrom
weyert:2140-add-force-flush-spanexporter
May 13, 2021
Merged

feat: add forceFlush-function to the BasicTracerProvider-class#2191
vmarchaud merged 9 commits into
open-telemetry:mainfrom
weyert:2140-add-force-flush-spanexporter

Conversation

@weyert

@weyert weyert commented May 7, 2021

Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

Short description of the changes

  • Introduces the forceFlush-method on the TracerProvider classes which calls the same named method on the registered span processors

@codecov

codecov Bot commented May 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2191 (9c6e351) into main (1758fa6) will decrease coverage by 0.03%.
The diff coverage is 90.62%.

❗ Current head 9c6e351 differs from pull request most recent head 339a610. Consider uploading reports for the commit 339a610 to get more accurate results

@@            Coverage Diff             @@
##             main    #2191      +/-   ##
==========================================
- Coverage   92.75%   92.72%   -0.04%     
==========================================
  Files         141      141              
  Lines        5055     5087      +32     
  Branches     1042     1045       +3     
==========================================
+ Hits         4689     4717      +28     
- Misses        366      370       +4     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/config.ts 86.84% <ø> (ø)
...s/opentelemetry-tracing/src/BasicTracerProvider.ts 94.49% <90.62%> (-1.61%) ⬇️
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Comment thread packages/opentelemetry-tracing/src/BasicTracerProvider.ts Outdated

@obecny obecny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor / suggestion

Comment thread packages/opentelemetry-tracing/src/BasicTracerProvider.ts Outdated
@dyladan dyladan linked an issue May 12, 2021 that may be closed by this pull request

@dyladan dyladan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @obecny's nit but otherwise lgtm

@vmarchaud
vmarchaud merged commit 6885278 into open-telemetry:main May 13, 2021
@weyert
weyert deleted the 2140-add-force-flush-spanexporter branch May 13, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TracerProvider should expose forceFlush()

5 participants