feat: add forceFlush-function to the BasicTracerProvider-class#2191
Merged
vmarchaud merged 9 commits intoMay 13, 2021
Merged
Conversation
weyert
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
May 7, 2021 15:01
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
- Coverage 92.75% 92.72% -0.04%
==========================================
Files 141 141
Lines 5055 5087 +32
Branches 1042 1045 +3
==========================================
+ Hits 4689 4717 +28
- Misses 366 370 +4
|
obecny
reviewed
May 7, 2021
obecny
approved these changes
May 11, 2021
vmarchaud
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
TracerProvidershould exposeforceFlush()#2140Short description of the changes
forceFlush-method on the TracerProvider classes which calls the same named method on the registered span processors