Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move initialization of const above first use #2170 #2171

Merged
merged 2 commits into from
May 1, 2021
Merged

fix: move initialization of const above first use #2170 #2171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f466d10
fix: move initialization of const above first use #2170
dyladan Apr 30, 2021
c8ccab0
Merge branch 'main' into access-before-init
vmarchaud May 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/opentelemetry-tracing/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
import { ENVIRONMENT } from '@opentelemetry/core/src/utils/environment';

const env = getEnv();
const FALLBACK_OTEL_TRACES_SAMPLER = TracesSamplerValues.AlwaysOn;

/**
* Default configuration. For fields with primitive values, any user-provided
Expand All @@ -42,8 +43,6 @@ export const DEFAULT_CONFIG = {
},
};

const FALLBACK_OTEL_TRACES_SAMPLER = TracesSamplerValues.AlwaysOn;

/**
* Based on environment, builds a sampler, complies with specification.
* @param env optional, by default uses getEnv(), but allows passing a value to reuse parsed environment
Expand Down