Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-conventions: include built esm files in package #2167

Merged
merged 2 commits into from
May 1, 2021

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Apr 28, 2021

Which problem is this PR solving?

While testing ESM in contrib (open-telemetry/opentelemetry-js-contrib#459) I noticed webpack was still using cjs files for @opentelemetry/semantic-conventions, turns out I missed including esm files for this one package in #2112 and webpack was tolerant enough to not warn about it

Short description of the changes

Include esm files in packed @opentelemetry/semantic-conventions

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #2167 (afe8915) into main (329cf92) will not change coverage.
The diff coverage is n/a.

❗ Current head afe8915 differs from pull request most recent head 0358b20. Consider uploading reports for the commit 0358b20 to get more accurate results

@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files         140      140           
  Lines        5002     5002           
  Branches     1029     1029           
=======================================
  Hits         4642     4642           
  Misses        360      360           

@dyladan dyladan changed the title fix(semantic-conventions): include built esm files in package feat(semantic-conventions): include built esm files in package Apr 28, 2021
@dyladan
Copy link
Member

dyladan commented Apr 28, 2021

changed title from fix to feat, this is not a bug

edit: removed feat also. this isn't really a feature either

@dyladan dyladan added the enhancement New feature or request label Apr 28, 2021
@dyladan dyladan changed the title feat(semantic-conventions): include built esm files in package semantic-conventions: include built esm files in package Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants