fix: add isEnabled to InstrumentationBase #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemk
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2135 +/- ##
==========================================
- Coverage 92.78% 92.77% -0.02%
==========================================
Files 140 140
Lines 4979 4981 +2
Branches 1028 1028
==========================================
+ Hits 4620 4621 +1
- Misses 359 360 +1
|
|
Hmm, don't think I can retrigger CI without any pushes. GH actions failed due to an internal error |
Flarna
reviewed
Apr 21, 2021
packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts
Outdated
Show resolved
Hide resolved
seemk
changed the title
johnbley
approved these changes
Apr 21, 2021
dyladan
approved these changes
Apr 21, 2021
Flarna
approved these changes
Apr 21, 2021
|
@obecny @vmarchaud need 1 more maintainer review. Would like to have this in for 0.19 release |
vmarchaud
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#2131
Short description of the changes
Instrumentations need access to the enabled flag, this is to avoid defining it multiple times.