-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle OTEL_TRACES_SAMPLER env var #2111
feat: handle OTEL_TRACES_SAMPLER env var #2111
Conversation
Adds support for OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG, in favor of OTEL_SAMPLING_PROBABILITY.
Codecov Report
@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 92.73% 92.64% -0.09%
==========================================
Files 138 139 +1
Lines 4927 4964 +37
Branches 1016 1026 +10
==========================================
+ Hits 4569 4599 +30
- Misses 358 365 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good
lgtm, but could you mark this as breaking and add documentation as how to migrate form If I understand correctly it would be: old:
new:
|
I've already added the "breaking" label which should generated the correct entry in the changelog |
@naseemkullah @vmarchaud fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally ok, just one concern with the hardcoded values, please create enum / const for that
@obecny done, let me know if we need anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx for the changes
Adds support for OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG, in favor of
OTEL_SAMPLING_PROBABILITY.
Which problem is this PR solving?
Short description of the changes
OTEL_SAMPLING_PROBABILITY
OTEL_TRACES_SAMPLER
andOTEL_TRACES_SAMPLER_ARG