-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): allow to configure exporter by environment #1676 #2100
feat(tracing): allow to configure exporter by environment #1676 #2100
Conversation
This comment has been minimized.
This comment has been minimized.
9288511
to
75e963b
Compare
This is the first part to allow tracing SDKs to load exporter via environment, this will allows higher level SDKs that have exporters has dependencies to register them to be loaded via the environment (as discussed in SIG). |
75e963b
to
f87c346
Compare
Codecov Report
@@ Coverage Diff @@
## main #2100 +/- ##
==========================================
+ Coverage 92.71% 92.73% +0.02%
==========================================
Files 141 141
Lines 5037 5055 +18
Branches 1037 1042 +5
==========================================
+ Hits 4670 4688 +18
Misses 367 367
|
A test which actually registers an exporter and uses it via env would be nice. |
be8a185
to
f8e93da
Compare
Added ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one concern with shutdown and some minor things
packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Bartlomiej Obecny <[email protected]>
Co-authored-by: Bartlomiej Obecny <[email protected]>
05be8ca
to
6f63e57
Compare
Opening PR for feedback, see #1676 for discussions
Fixes #1676