Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception.type should always be a string #2086

Merged
merged 4 commits into from
Apr 8, 2021
Merged

fix: exception.type should always be a string #2086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
478c74d
fix: exception.type should always be a string
Apr 8, 2021
b80b7db
chore: test exception with numeric code
Apr 8, 2021
1d5ee08
fix: test for exception with numeric code
Apr 8, 2021
bf267ad
Merge branch 'main' into fix/exceptionType
YanivD Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opentelemetry-tracing/src/Span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export class Span implements api.Span, ReadableSpan {
attributes[ExceptionAttribute.MESSAGE] = exception;
} else if (exception) {
if (exception.code) {
attributes[ExceptionAttribute.TYPE] = exception.code;
attributes[ExceptionAttribute.TYPE] = exception.code.toString();
} else if (exception.name) {
attributes[ExceptionAttribute.TYPE] = exception.name;
}
Expand Down
18 changes: 18 additions & 0 deletions packages/opentelemetry-tracing/test/Span.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,5 +719,23 @@ describe('Span', () => {
assert.deepStrictEqual(event.time, [0, 123]);
});
});

describe('when exception code is numeric', () => {
it('should record an exception with string value', () => {
const span = new Span(
tracer,
ROOT_CONTEXT,
name,
spanContext,
SpanKind.CLIENT
);
assert.strictEqual(span.events.length, 0);
span.recordException({ code: 12 });
const event = span.events[0];
assert.deepStrictEqual(event.attributes, {
[ExceptionAttribute.TYPE]: '12',
});
});
});
});
});