Check type of navigator.sendBeacon #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
dyladan
changed the title
Flarna
approved these changes
Mar 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
+ Coverage 92.98% 93.00% +0.01%
==========================================
Files 152 152
Lines 5934 5934
Branches 1247 1247
==========================================
+ Hits 5518 5519 +1
+ Misses 416 415 -1
|
vmarchaud
approved these changes
Mar 23, 2021
obecny
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblock #1825 by fixing its compilation error. Also a stricter and safer check anyways.