Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add husky to renovate ignore #2033

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 22, 2021

Prevent PRs like #1924 because husky 5 carries an incompatible license

renovate.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2033 (44e763a) into main (f045eef) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
- Coverage   92.99%   92.98%   -0.02%     
==========================================
  Files         152      152              
  Lines        5926     5926              
  Branches     1245     1245              
==========================================
- Hits         5511     5510       -1     
- Misses        415      416       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan dyladan force-pushed the renovate-ignore-husky branch from 6162acc to 44e763a Compare March 22, 2021 14:01
@dyladan dyladan merged commit e5fedbd into open-telemetry:main Mar 22, 2021
@dyladan dyladan deleted the renovate-ignore-husky branch March 22, 2021 15:39
rauno56 pushed a commit to rauno56/opentelemetry-js that referenced this pull request Mar 23, 2021
@Flarna
Copy link
Member

Flarna commented Jul 2, 2021

Seems husky uses again MIT license so maybe we should consider to update it.

@obecny
Copy link
Member

obecny commented Jul 2, 2021

Seems husky uses again MIT license so maybe we should consider to update it.

make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants