-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: specification compliant resource collision precedence #1975
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
+ Coverage 92.87% 92.92% +0.05%
==========================================
Files 152 152
Lines 5922 5922
Branches 1245 1245
==========================================
+ Hits 5500 5503 +3
+ Misses 422 419 -3
|
Can you add this to the upgrade guidelines in the README since it is a breaking change? |
@dyladan I have added the new entry. |
Co-authored-by: Daniel Dyla <[email protected]>
Looks good but I want to wait for @obecny since this PR is only 1 day old and it was a weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
one comment, hope you can address it before merge.
Co-authored-by: Bartlomiej Obecny <[email protected]>
Resource Merge Spec
This commit updates the resource collision precedence.