Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct tracer docs #1901

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 4, 2021

Remove context related docs from Tracer API as they are wrong since #1764.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1901 (7701fd2) into main (83343ef) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
+ Coverage   92.44%   92.81%   +0.37%     
==========================================
  Files         159      176      +17     
  Lines        5146     6080     +934     
  Branches     1089     1287     +198     
==========================================
+ Hits         4757     5643     +886     
- Misses        389      437      +48     
Impacted Files Coverage Δ
...ry-exporter-collector/src/CollectorExporterBase.ts 92.45% <0.00%> (ø)
...ntelemetry-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...rumentation/src/platform/browser/old/autoLoader.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...ackages/opentelemetry-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
packages/opentelemetry-web/src/types.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 99.23% <0.00%> (ø)
packages/opentelemetry-web/src/utils.ts 94.66% <0.00%> (ø)
... and 8 more

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan added document Documentation-related express labels Feb 4, 2021
@dyladan dyladan merged commit 9981763 into open-telemetry:main Feb 5, 2021
@dyladan dyladan deleted the fix-tracer-doc branch February 5, 2021 15:41
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants