-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct tracer docs #1901
Merged
dyladan
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix-tracer-doc
Feb 5, 2021
Merged
doc: correct tracer docs #1901
dyladan
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix-tracer-doc
Feb 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
requested review from
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
February 4, 2021 13:50
Codecov Report
@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
+ Coverage 92.44% 92.81% +0.37%
==========================================
Files 159 176 +17
Lines 5146 6080 +934
Branches 1089 1287 +198
==========================================
+ Hits 4757 5643 +886
- Misses 389 437 +48
|
johnbley
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dyladan
approved these changes
Feb 4, 2021
MSNev
approved these changes
Feb 4, 2021
naseemkullah
approved these changes
Feb 5, 2021
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <[email protected]>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove context related docs from
Tracer
API as they are wrong since #1764.