-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove NoRecordingSpan #1900
Merged
dyladan
merged 9 commits into
open-telemetry:main
from
dynatrace-oss-contrib:rm-norecordingspan
Feb 8, 2021
Merged
chore: remove NoRecordingSpan #1900
dyladan
merged 9 commits into
open-telemetry:main
from
dynatrace-oss-contrib:rm-norecordingspan
Feb 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoRecordingSpan doesn't add anything on top of NoopSpan and it's only used at one place. Remove it in favor of NoopSpan.
Flarna
requested review from
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
February 4, 2021 11:32
Codecov Report
@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
- Coverage 92.75% 92.68% -0.07%
==========================================
Files 173 172 -1
Lines 5973 5963 -10
Branches 1269 1268 -1
==========================================
- Hits 5540 5527 -13
- Misses 433 436 +3
|
johnbley
reviewed
Feb 4, 2021
johnbley
approved these changes
Feb 4, 2021
dyladan
approved these changes
Feb 4, 2021
MSNev
approved these changes
Feb 4, 2021
vmarchaud
approved these changes
Feb 5, 2021
obecny
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoRecordingSpan
doesn't add anything on top ofNoopSpan
and it's only used atonefew places.Remove it in favor of
NoopSpan
.Nice side effect is that instrumentation http is no longer depending on core.