-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More specific api type names #1874
More specific api type names #1874
Conversation
dyladan
commented
Jan 27, 2021
•
edited
Loading
edited
- AttributeValue => SpanAttributeValue
- Attributes => SpanAttributes
- EntryTtl => BaggageEntryTtl
- EntryValue => BaggageEntryValue
- Status => SpanStatus
- StatusCode => SpanStatusCode
- AttributeValue => SpanAttributeValue - Attributes => SpanAttributes - EntryTtl => BaggageEntryTtl - EntryValue => BaggageEntryValue - Status => SpanStatus - StatusCode => SpanStatusCode
Codecov Report
@@ Coverage Diff @@
## main #1874 +/- ##
==========================================
- Coverage 92.72% 92.37% -0.36%
==========================================
Files 174 157 -17
Lines 6038 5104 -934
Branches 1283 1085 -198
==========================================
- Hits 5599 4715 -884
+ Misses 439 389 -50
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected before that both span/metrics would share the same attributes types, is this a first step to be able to seperate them later on ?
This PR should be mentioned in https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines |
That is not the case at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls update upgrade guidelines to 0.17