Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific api type names #1874

Merged
merged 7 commits into from
Feb 4, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 27, 2021

  • AttributeValue => SpanAttributeValue
  • Attributes => SpanAttributes
  • EntryTtl => BaggageEntryTtl
  • EntryValue => BaggageEntryValue
  • Status => SpanStatus
  • StatusCode => SpanStatusCode

- AttributeValue => SpanAttributeValue
- Attributes => SpanAttributes
- EntryTtl => BaggageEntryTtl
- EntryValue => BaggageEntryValue
- Status => SpanStatus
- StatusCode => SpanStatusCode
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1874 (f130439) into main (65277da) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
- Coverage   92.72%   92.37%   -0.36%     
==========================================
  Files         174      157      -17     
  Lines        6038     5104     -934     
  Branches     1283     1085     -198     
==========================================
- Hits         5599     4715     -884     
+ Misses        439      389      -50     
Impacted Files Coverage Δ
...ages/opentelemetry-api/src/trace/SamplingResult.ts 100.00% <ø> (ø)
...metry-core/src/trace/sampler/ParentBasedSampler.ts 83.87% <ø> (ø)
...ges/opentelemetry-exporter-jaeger/src/transform.ts 100.00% <ø> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100.00% <ø> (ø)
...ges/opentelemetry-instrumentation-grpc/src/grpc.ts 92.52% <ø> (ø)
...es/opentelemetry-instrumentation-grpc/src/utils.ts 93.93% <ø> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 95.54% <ø> (ø)
...es/opentelemetry-instrumentation-http/src/utils.ts 98.55% <ø> (ø)
...s/opentelemetry-plugin-grpc-js/src/client/utils.ts 93.25% <ø> (ø)
...-plugin-grpc-js/src/server/clientStreamAndUnary.ts 100.00% <ø> (ø)
... and 31 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected before that both span/metrics would share the same attributes types, is this a first step to be able to seperate them later on ?

@Flarna
Copy link
Member

Flarna commented Jan 27, 2021

This PR should be mentioned in https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines

@dyladan
Copy link
Member Author

dyladan commented Jan 27, 2021

I expected before that both span/metrics would share the same attributes types, is this a first step to be able to seperate them later on ?

That is not the case at the moment. Attributes is for spans and Labels is for metrics (string values only).

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update upgrade guidelines to 0.17

@dyladan dyladan merged commit 3b5892b into open-telemetry:main Feb 4, 2021
@dyladan dyladan deleted the specific-names branch February 4, 2021 18:00
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants