chore: adding johnbley to js approvers #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
Flarna,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
- Coverage 92.62% 92.60% -0.02%
==========================================
Files 174 174
Lines 6045 6045
Branches 1286 1286
==========================================
- Hits 5599 5598 -1
- Misses 446 447 +1
|
naseemkullah
approved these changes
Jan 20, 2021
Flarna
approved these changes
Jan 20, 2021
vmarchaud
approved these changes
Jan 20, 2021
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to propose @johnbley as js approver. He is contributing to this project with web related stuff and I believe it would be great to have him as an approver too.
https://github.com/open-telemetry/opentelemetry-js-contrib/commits?author=johnbley
https://github.com/open-telemetry/opentelemetry-js/commits?author=johnbley