-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge grpc-js into grpc instrumentation #1657 #1806
feat: merge grpc-js into grpc instrumentation #1657 #1806
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 92.46% 92.78% +0.32%
==========================================
Files 161 182 +21
Lines 5229 6363 +1134
Branches 1110 1340 +230
==========================================
+ Hits 4835 5904 +1069
- Misses 394 459 +65
|
packages/opentelemetry-instrumentation-grpc/src/grpc-js/client/patches.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-instrumentation-grpc/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
245e321
to
3950c08
Compare
I've rewrote the |
a916c67
to
9f93693
Compare
9f93693
to
61cce95
Compare
pls remove locks |
61cce95
to
d890b2a
Compare
cc @obecny i've rebased + removed package locks |
I splitted this PR into 3 commits following my process:
instrumentation
class to load bothgrpc
andgrpc-js
patches.Fixes #1657