Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opentelemetry-core): fixed timeInputToHrTime when time is Date type #1784

Merged
merged 5 commits into from
Jan 12, 2021
Merged

fix(opentelemetry-core): fixed timeInputToHrTime when time is Date type #1784

merged 5 commits into from
Jan 12, 2021

Conversation

zoomchan-cxj
Copy link
Contributor

@zoomchan-cxj zoomchan-cxj commented Dec 28, 2020 •
edited
Loading

Short description of the changes

  • function timeInputToHrTime when param time is Date type, the first value of returned array is not correct which should be divided by 1000

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 28, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Dec 28, 2020 •
edited
Loading

Codecov Report

Merging #1784 (d9d0550) into master (0545122) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         173      173           
  Lines        6012     6012           
  Branches     1287     1287           
=======================================
  Hits         5559     5559           
  Misses        453      453
Impacted Files Coverage Δ
packages/opentelemetry-core/src/common/time.ts 95.38% <100.00%> (ø)

@zoomchan-cxj zoomchan-cxj requested a review from obecny December 30, 2020 03:53
obecny
obecny approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the bug Something isn't working label Dec 30, 2020
@Flarna Flarna mentioned this pull request Jan 5, 2021
Closed
@dyladan dyladan merged commit 73b8bd0 into open-telemetry:master Jan 12, 2021
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@pichlermarc
chore(deps): unpin @opentelemetry/* in fastify instrumentation and my…
da94ee9 
…sql example (open-telemetry#1784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@dyladan dyladan dyladan approved these changes

@obecny obecny obecny approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoomchan-cxj @obecny @dyladan @mwear