Allow zero/negative performance timings #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbley
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
- Coverage 92.62% 92.60% -0.02%
==========================================
Files 174 174
Lines 6049 6048 -1
Branches 1289 1288 -1
==========================================
- Hits 5603 5601 -2
- Misses 446 447 +1
|
obecny
reviewed
Dec 30, 2020
| @@ -185,19 +185,23 @@ describe('utils', () => { | |||
| assert.strictEqual(args[1], 123); | |||
| }); | |||
| }); | |||
| describe('when entry has time equal to 0', () => { | |||
| describe('when entry is not numeric', () => { | |||
There was a problem hiding this comment.
I think you should still have unit test when time is 0 - this is basically what you are fixing in this PR right ?
There was a problem hiding this comment.
Good call; I updated the positive test to check 0, a negative number, and a positive number.
dyladan
approved these changes
Jan 4, 2021
|
Now @johnbley is an approver this meets merge requirements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes