-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up API for release #1759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
- Coverage 92.07% 91.87% -0.21%
==========================================
Files 166 166
Lines 5593 5609 +16
Branches 1199 1201 +2
==========================================
+ Hits 5150 5153 +3
- Misses 443 456 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, don't see any blocker here
@@ -14,7 +14,7 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
import { NoopTracerProvider } from '@opentelemetry/api'; | |||
import { NoopTracerProvider } from '@opentelemetry/api/build/src/trace/NoopTracerProvider'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it mean that NoopTracerProvider is not available or it is in different namespace ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NoopTracer provider is not explicitly exported by the package index so the only way to get it is by its full path. This means it is not part of the API that we claim to be "stable" and could move, change name, be removed, or similar. It also means it will not show up in autocomplete and such when people try to explore the package so it will prevent some confusion.
I'm closing since the api has been moved anyway |
Summary
Noop*
classesimport {} from '@opentelemetry/api/build/src/folder/file';
but in the future, other package tests should probably not depend on these internal details of the API if possible.NOOP_*
constantsINVALID_*
SpanContext
constantsapi.StatusCode
toapi.SpanStatusCode
createContextKey
tocontext.createKey
api.EntryValue
toapi.BaggageEntryValue
api.EntryTtl
toapi.BaggageEntryTtl