-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creating one auto loader for instrumentation and old plugins #1731
Conversation
@open-telemetry/javascript-approvers have a look before I start moving tests and create new one |
Codecov Report
@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
+ Coverage 92.18% 92.47% +0.29%
==========================================
Files 167 173 +6
Lines 5845 6019 +174
Branches 1256 1287 +31
==========================================
+ Hits 5388 5566 +178
+ Misses 457 453 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me except the one weird type assertion thing
packages/opentelemetry-instrumentation/src/platform/node/old/autoLoader.ts
Show resolved
Hide resolved
FYI next issues and plans (after this will be merged) |
@obecny looks like everyone who is going to review has done so. if you're ready i'm ok if you merge this |
Which problem is this PR solving?
Short description of the changes
So mixing old plugins and new instrumentation is possible now
Update:
test added