-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new gRPC default port #1725
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1725 +/- ##
==========================================
- Coverage 92.11% 92.09% -0.02%
==========================================
Files 166 166
Lines 5591 5591
Branches 1198 1198
==========================================
- Hits 5150 5149 -1
- Misses 441 442 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test that our collector exporter is compatible with the 0.16 version of the collector ?
@vmarchaud I used examples/collector-exporter-node to test my modification and I update collector version (0.16.0):
And everything is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this change according to spec should be also applied to the rest of collectors as port 55680
is gone
Please update also each README.md with information of last used version of collector (it is in top of the readme)
@obecny It's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the build
@jufab if you fix the lint I can merge this |
I have a problem with the linter. Example I fix it manually I run npm run lint:fix, and after that, I have What's wrong with linter? I have no idea. |
You probably have an out-of-date version of the linting dependencies. I would do |
I tried without success so I reinstalled all. |
Which problem is this PR solving?
New Default gRPC OTEL Default port.
Short description of the changes
Use new gRPC Otel default port => open-telemetry/opentelemetry-specification#1221