Feat: Added Amazon EKS Resource Detector #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKelvinLo
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
KKelvinLo
changed the title
KKelvinLo
force-pushed
the
eks-resource-detector
branch
from
b1f9ba7 to
7d6a1c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1669 +/- ##
==========================================
- Coverage 91.38% 91.35% -0.03%
==========================================
Files 164 165 +1
Lines 5059 5138 +79
Branches 1048 1056 +8
==========================================
+ Hits 4623 4694 +71
- Misses 436 444 +8
|
|
@dyladan Hi Daniel, would really appreciate any comments or review of the code when possible thanks! |
dyladan
approved these changes
Dec 2, 2020
vmarchaud
approved these changes
Dec 2, 2020
|
@obecny would really appreciate a review and merge if possible, thanks! |
obecny
reviewed
Dec 2, 2020
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/test/detectors/AwsEksDetector.test.ts
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Outdated
Show resolved
Hide resolved
|
@KKelvinLo something wrong either with merge or rebase with latest master I suddenly see here changes which has nothing to do with yr PR. |
KKelvinLo
force-pushed
the
eks-resource-detector
branch
from
63aca8c to
20d7ea4
Compare
|
@obecny Consistencies resolved and rebased master, cheers! |
obecny
reviewed
Dec 3, 2020
packages/opentelemetry-resource-detector-aws/test/detectors/AwsEksDetector.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-resource-detector-aws/src/detectors/AwsEksDetector.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
If you can review @dyladan, @anuraaga, thanks a lot!