fix(plugin-fetch): check if PerformanceObserver exists #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exists before using it.
mhennoch
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 92.58% 92.38% -0.21%
==========================================
Files 174 157 -17
Lines 6045 5108 -937
Branches 1286 1091 -195
==========================================
- Hits 5597 4719 -878
+ Misses 448 389 -59 |
|
Would like @obecny input on this |
obecny
reviewed
Nov 18, 2020
| @@ -225,7 +228,9 @@ export class FetchPlugin extends core.BasePlugin<Promise<Response>> { | |||
| response: FetchResponse | |||
| ) { | |||
| const endTime = core.hrTime(); | |||
| spanData.observer.disconnect(); | |||
| if (spanData.observer) { | |||
There was a problem hiding this comment.
you can shorten the whole if to one liner as it was previously just add ?
Suggested change
| if (spanData.observer) { | |
| spanData.observer?.disconnect(); |
|
|
||
| describe('when PerformanceObserver is undefined', () => { | ||
| beforeEach(done => { | ||
| Object.defineProperty(window, 'PerformanceObserver', { |
There was a problem hiding this comment.
please use sandbox.stub for that
| @@ -174,6 +174,9 @@ export class FetchPlugin extends core.BasePlugin<Promise<Response>> { | |||
| ): void { | |||
| let resources: PerformanceResourceTiming[] = resourcesObserver.entries; | |||
| if (!resources.length) { | |||
| if (!performance.getEntriesByType) { | |||
There was a problem hiding this comment.
Please add unit test for that - use sandbox
There was a problem hiding this comment.
Done, wanted to do a cleaner solution but ran into a bunch of issues
dyladan
approved these changes
Dec 16, 2020
|
waiting for one more reviewer. i'm fine to merge without if @obecny is |
vmarchaud
approved these changes
Jan 20, 2021
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes