Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: change status codes from grpc status codes #1644

Merged
merged 7 commits into from
Nov 5, 2020
Merged

fix!: change status codes from grpc status codes #1644

merged 7 commits into from
Nov 5, 2020

Conversation

srikanthccv
Copy link
Member

closes #1634

@codecov
Copy link

codecov bot commented Nov 1, 2020 •
edited
Loading

Codecov Report

Merging #1644 into master will increase coverage by 0.03%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   91.31%   91.35%   +0.03%     
==========================================
  Files         165      165              
  Lines        5066     5042      -24     
  Branches     1044     1040       -4     
==========================================
- Hits         4626     4606      -20     
+ Misses        440      436       -4
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/http.ts 97.28% <0.00%> (ø)
...ackages/opentelemetry-shim-opentracing/src/shim.ts 87.70% <0.00%> (ø)
packages/opentelemetry-tracing/src/Span.ts 98.09% <ø> (ø)
packages/opentelemetry-api/src/trace/status.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-exporter-jaeger/src/transform.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100.00% <100.00%> (ø)
...s/opentelemetry-plugin-grpc-js/src/client/utils.ts 93.25% <100.00%> (ø)
...-plugin-grpc-js/src/server/clientStreamAndUnary.ts 100.00% <100.00%> (ø)
...y-plugin-grpc-js/src/server/serverStreamAndBidi.ts 100.00% <100.00%> (ø)
packages/opentelemetry-plugin-grpc-js/src/utils.ts 96.15% <100.00%> (+3.84%) ⬆️
... and 4 more

@srikanthccv srikanthccv mentioned this pull request Nov 2, 2020
Closed
dyladan
dyladan approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I know it was a huge amount of work

@dyladan dyladan changed the title fix: change status codes from grpc status codes fix!: change status codes from grpc status codes Nov 5, 2020
@dyladan dyladan merged commit dec432d into open-telemetry:master Nov 5, 2020
@blumamir blumamir mentioned this pull request Dec 9, 2020
Closed
obecny
obecny reviewed Dec 11, 2020
View reviewed changes
packages/opentelemetry-tracing/src/Span.ts
@@ -51,7 +51,7 @@ export class Span implements api.Span, ReadableSpan {
readonly instrumentationLibrary: InstrumentationLibrary;
name: string;
status: api.Status = {
code: api.CanonicalCode.OK,
code: api.StatusCode.UNSET,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have "UNSET" now as default ?
Is this required by spec if so where is it?
Currently all spans are being exported with status "UNSET" previously if they were ok they were exported as "OK"
@dyladan ^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I have found this to be set as default, but shouldn't the span be set to "OK" once it is finished and there were no errors ?

@blumamir blumamir mentioned this pull request Dec 13, 2020
Open
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@srikanthccv @dyladan
fix!: change status codes from grpc status codes (open-telemetry#1644)
4700014 
Co-authored-by: Daniel Dyla <[email protected]>
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@srikanthccv @dyladan
fix!: change status codes from grpc status codes (open-telemetry#1644)
e9b378f 
Co-authored-by: Daniel Dyla <[email protected]>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@sberz
fix(mongodb): remove broken type export V4Connection (open-telemetr…
ff29576 
…y#1644)

The type `V4Connection` re-introduced in open-telemetry#1170 is missing any type
definitions or imports for `Document`, breaking the build with
Typescript strict mode.
`V4Connection` in `types.ts` is not referenced anywhere (the type
definition in `internal-types.ts` is used. So lets just drop this type
definition.

BREAKING CHANGE: removes the broken exported type `V4Connection`.
Fixes open-telemetry#1639

Signed-off-by: Simon Berz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny left review comments

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set status with StatusCode (Unset, Ok, Error)
5 participants
@srikanthccv @obecny @dyladan @vmarchaud @mayurkale22