-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: do not convert ids to base64 #1583
Conversation
@dyladan I'm in a process of upgrading to latest proto v.0.5.0 and Im' already modifying the similar piece of code. I'm affraid they might be merging conflicts. Not sure how urgent is this fix as in fact the fix is required for next proto, and our collector exporter is not compatible with next version anyway (talking about metrics mainly, for tracing I think this is the only change), but that means that if you want to upgrade you wont be able to use metrics and traces in newest version. So upgrading might not make sense in such case, unless you only use trace. |
So you're saying we should wait for the proto 0.5.0 upgrade before doing this? That's fine if that's what you want to do. |
@dyladan just checked about removing conversion on top of my PR -> #1588. |
Do you mean just update the ids in the tests? |
Yes, after @vmarchaud tests it was the last thing that was still missing for proto v.0.5.0 |
ok then i'm closing this |
This fixes #1513
@obecny the gRPC export is still incorrect but I don't understand the gRPC/proto pipeline to understand how to fix it.