docs: fix and update getting-started #1553
Conversation
svrnm
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 158 158
Lines 4882 4882
Branches 988 988
=======================================
Hits 4543 4543
Misses 339 339 |
| .then(result => { | ||
| res.send(result.data); |
There was a problem hiding this comment.
nit: axios docs refers to this as response rather than result
There was a problem hiding this comment.
it is a bit difficult to see real changes, as it looks like you have created a new files, did you delete old files without changing the name or its a git which messes the history?.
You mentioned that you updated screenshots, but I only see 2 that were deleted, what's happened with them ?
|
@obecny thanks for calling this out. Regarding the images the Files changed view here on github tells me that the images have been modified with a decreased file size, not deleted. the deleted file (tracing.ts) is now in ts-example/traced-example. I didn't move that file but created a new one, I guess that's why it is not marked as "moved". |
|
@svrnm pls fix the conflicts |
|
@obecny TBH I have no idea how I should resolve this conflict. Any guidance is appreciated. |
|
@obecny Never mind I figured out, asking google the right questions helps ;-) |
* docs: document merge reqiurements * docs: remove redundant wording * docs: remove redundant wording * docs: lint
As mentioned in #1509 (comment) there are a few other issues in the getting started guide I fixed: Typos, outdated images for zipkin, version bumps and bringing the TypeScript example on par with the Javascript ones.