Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): remove x-opentelemetry-outgoing-request header #1547 #1548

Merged
merged 4 commits into from
Oct 1, 2020

Conversation

vmarchaud
Copy link
Member

Fixes #1547

@vmarchaud vmarchaud self-assigned this Sep 19, 2020
@vmarchaud vmarchaud added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2020
@vmarchaud vmarchaud force-pushed the remove-http-ot-header branch from 73ad589 to fa9e376 Compare September 19, 2020 16:26
@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #1548 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   93.05%   92.92%   -0.13%     
==========================================
  Files         158      156       -2     
  Lines        4882     4851      -31     
  Branches      988      978      -10     
==========================================
- Hits         4543     4508      -35     
- Misses        339      343       +4     
Impacted Files Coverage Δ
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <ø> (ø)
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 85.71% <ø> (-0.37%) ⬇️
...elemetry-exporter-zipkin/src/platform/node/util.ts 96.96% <ø> (-3.04%) ⬇️
...s/opentelemetry-plugin-grpc-js/src/client/utils.ts 93.25% <ø> (-0.15%) ⬇️
packages/opentelemetry-plugin-grpc-js/src/utils.ts 92.30% <ø> (-0.80%) ⬇️
packages/opentelemetry-plugin-grpc/src/utils.ts 90.90% <ø> (-0.99%) ⬇️
packages/opentelemetry-plugin-http/src/http.ts 97.81% <ø> (-0.07%) ⬇️
packages/opentelemetry-plugin-http/src/utils.ts 97.36% <ø> (-0.06%) ⬇️
...telemetry-plugin-grpc-js/src/server/patchServer.ts 90.00% <100.00%> (-3.55%) ⬇️
packages/opentelemetry-plugin-grpc/src/grpc.ts 93.71% <100.00%> (-0.60%) ⬇️
... and 3 more

@vmarchaud vmarchaud force-pushed the remove-http-ot-header branch from fa9e376 to 27a4367 Compare September 19, 2020 16:32
@vmarchaud vmarchaud force-pushed the remove-http-ot-header branch from 27a4367 to 7279b9a Compare September 19, 2020 16:37
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just wondering if some of tests could be converted using the new "suppress" feature now, WDYT ?

@vmarchaud
Copy link
Member Author

just wondering if some of tests could be converted using the new "suppress" feature now, WDYT ?

Well i hesitated about that but since the supress feature is only implement in the tracing sdk, i would find it weird to add tests for that in the instrumentation, but i'm open to add some if anyone find it really important.

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to see this being removed!

@obecny obecny added the enhancement New feature or request label Oct 1, 2020
@obecny obecny merged commit f731c65 into open-telemetry:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove x-opentelemetry-outgoing-request http header
5 participants