-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include missing proto files in npm distribution #1539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
September 16, 2020 15:28
obecny
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx for spotting that
Codecov Report
@@ Coverage Diff @@
## master #1539 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 154 154
Lines 4762 4762
Branches 951 951
=======================================
Hits 4468 4468
Misses 294 294 |
vmarchaud
approved these changes
Sep 17, 2020
legendecas
approved these changes
Sep 17, 2020
mwear
approved these changes
Sep 18, 2020
naseemkullah
approved these changes
Sep 18, 2020
mayurkale22
approved these changes
Sep 21, 2020
mihirsoni
pushed a commit
to mihirsoni/opentelemetry-js
that referenced
this pull request
Sep 21, 2020
…1539) Co-authored-by: Mayur Kale <[email protected]>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: release main * chore: release main
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
* chore: release main * chore: release main
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
* chore: release main * chore: release main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#1538
#1524
proto files from build directory of
@opentelemetry/exporter-collector-proto
and@opentelemetry/exporter-collector-grpc
are not published to npm in v0.11.0, causing error message about missing files to be logged when package is used, and exporter to not work.Short description of the changes
Added the protos folder to the
"files"
section ofpackage.json
.Validated the fix with
npm publish --dry-run
:those files where missing before the change, and appear after the fix is applied.