Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decrease level of unsupported-version logs to warn #1532

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

naseemkullah
Copy link
Member

Which problem is this PR solving?

  • There are situations when using a non instrumentable version of a module are unavoidable for the moment. The behaviour to skip instrumentation is correct, though merits a warning as this generally means that the non-instrumented module is due for an update.

Short description of the changes

  • Reduces the log level from error to warn when skipping non supported versions of modules.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1532 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1532   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files         154      154           
  Lines        4762     4762           
  Branches      951      951           
=======================================
  Hits         4468     4468           
  Misses        294      294           
Impacted Files Coverage Δ
...telemetry-node/src/instrumentation/PluginLoader.ts 93.82% <0.00%> (ø)

@dyladan
Copy link
Member

dyladan commented Sep 15, 2020

Please update the PR name to something that will make more sense in the automated changelog

@dyladan dyladan added the enhancement New feature or request label Sep 15, 2020
@naseemkullah naseemkullah changed the title fix: decrease log level from error, since behaviour not erroneous fix: decrease level of non-supported-version logs Sep 15, 2020
@naseemkullah naseemkullah changed the title fix: decrease level of non-supported-version logs fix: decrease level of non-supported-version logs to warn Sep 15, 2020
@naseemkullah naseemkullah changed the title fix: decrease level of non-supported-version logs to warn fix: decrease level of unsupported-version logs to warn Sep 15, 2020
@dyladan dyladan changed the title fix: decrease level of unsupported-version logs to warn fix: decrease level of non-supported-version logs to warn Sep 15, 2020
@dyladan dyladan merged commit 3309ea4 into open-telemetry:master Sep 15, 2020
@naseemkullah naseemkullah deleted the decrease-log-level branch September 15, 2020 17:27
@naseemkullah naseemkullah changed the title fix: decrease level of non-supported-version logs to warn fix: decrease level of unsupported-version logs to warn Sep 15, 2020
mihirsoni pushed a commit to mihirsoni/opentelemetry-js that referenced this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants