-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): propagate spanContext only using API #1456 #1527
feat(api): propagate spanContext only using API #1456 #1527
Conversation
c1f21f2
to
797ae44
Compare
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
==========================================
- Coverage 93.43% 92.95% -0.48%
==========================================
Files 98 144 +46
Lines 3518 4332 +814
Branches 768 871 +103
==========================================
+ Hits 3287 4027 +740
- Misses 231 305 +74
|
I think the key shouldn't be duplicated. Having details like this in core results in further problems like various plugins depend on core. |
I was the one that originally put those context management functions in the SDK instead of API. The reason for this at the time was that I was thinking they were sdk-specific implementation details, but it has become clear since then that the API is not really that useful without them. I think they can be moved into the API. |
I will update the PR to move them into the API then 👍 |
1431e14
to
0b482fc
Compare
c241d6c
to
603acec
Compare
I've rebased the PR |
41c1fc1
to
3fd83fb
Compare
3fd83fb
to
76575d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pen-telemetry#1527) Co-authored-by: Bartlomiej Obecny <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
…pen-telemetry#1527) Co-authored-by: Bartlomiej Obecny <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
This one is a little bit tricky, since it was assume from the start that the API could only contains noop we put the context management utils into the core.As you can see in this PR, we need to get the spanContext stored inside the context from the Noop implementation, there are two way do to this:- duplicating the declaration of the key, one in the API's noop tracer and one inside the core for general usage.- moving the key declaration inside the API, but while at it why not move them all ? Specially since they all use API interfaces.Waiting for feedback before marking as non-draft !Fixes #1456