Align xhr span name with spec #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbley
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1476 +/- ##
=======================================
Coverage 93.99% 93.99%
=======================================
Files 153 153
Lines 4662 4663 +1
Branches 962 962
=======================================
+ Hits 4382 4383 +1
Misses 280 280
|
dyladan
approved these changes
Aug 28, 2020
vmarchaud
approved these changes
Aug 28, 2020
markwolff
approved these changes
Aug 28, 2020
mayurkale22
approved these changes
Aug 28, 2020
obecny
approved these changes
Aug 28, 2020
|
Why is the CLA check not returning? |
|
Closed and reopened to trigger the CLA check |
Have you tried turning it off and on again? 😄 |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
HTTP {method}names; the two plugins should be in agreement about this.Short description of the changes
HTTP {method}and adjust unit tests accordingly.