chore(zipkin): export ExporterConfig #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivkanya9146
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
=======================================
Coverage 91.19% 91.19%
=======================================
Files 165 165
Lines 5066 5066
Branches 1037 1037
=======================================
Hits 4620 4620
Misses 446 446 |
mayurkale22
approved these changes
Aug 28, 2020
|
Please fix the description |
|
@shivkanya9146 I updated the issue description to mention the issue it fixes. in the future can you make sure to make descriptive PR descriptions so that people know what they are reviewing? |
shivkanya9146
changed the title
ok, will make will sure in future. |
|
Title says jaeger but fix is actually applied to zipkin (opposite of #1478) |
shivkanya9146
changed the title
Done |
obecny
approved these changes
Sep 29, 2020
|
@shivkanya9146 can you please resolve the conflicts ? |
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* docs: document component maturity levels * docs: link maturity levels from README * Typo Co-authored-by: Marc Pichler <[email protected]> * Link header instead of owner --------- Co-authored-by: Marc Pichler <[email protected]>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
* docs: document component maturity levels * docs: link maturity levels from README * Typo Co-authored-by: Marc Pichler <[email protected]> * Link header instead of owner --------- Co-authored-by: Marc Pichler <[email protected]>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
* docs: document component maturity levels * docs: link maturity levels from README * Typo Co-authored-by: Marc Pichler <[email protected]> * Link header instead of owner --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1453