Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode #1432

Merged
merged 2 commits into from
Aug 20, 2020
Merged

docs(exporter-collector): CollectorTransportNode should be CollectorProtocolNode #1432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98c772e
docs(exporter-collector): change CollectorTransportNode to CollectorP…
hongbo-miao Aug 16, 2020
e7d25a6
Merge branch 'master' into patch-1
hongbo-miao Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/opentelemetry-exporter-collector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ Note, that this will only work if TLS is also configured on the server.

```js
const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/tracing');
const { CollectorExporter, CollectorTransportNode } = require('@opentelemetry/exporter-collector');
const { CollectorExporter, CollectorProtocolNode } = require('@opentelemetry/exporter-collector');

const collectorOptions = {
protocolNode: CollectorTransportNode.HTTP_JSON,
protocolNode: CollectorProtocolNode.HTTP_JSON,
serviceName: 'basic-service',
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/trace
headers: {
Expand All @@ -161,10 +161,10 @@ provider.register();

```js
const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/tracing');
const { CollectorExporter, CollectorTransportNode } = require('@opentelemetry/exporter-collector');
const { CollectorExporter, CollectorProtocolNode } = require('@opentelemetry/exporter-collector');

const collectorOptions = {
protocolNode: CollectorTransportNode.HTTP_PROTO,
protocolNode: CollectorProtocolNode.HTTP_PROTO,
serviceName: 'basic-service',
url: '<opentelemetry-collector-url>', // url is optional and can be omitted - default is http://localhost:55681/v1/trace
headers: {
Expand Down