fix: ignore non-number value on BaseBoundInstrument.update

[legendecas]

Which problem is this PR solving?

• OpenTelemetry can be used with pure JavaScript, there will be no build-time errors on writing counter.add(undefined) or counter.add({ arbitrary: 'value' }). Hence those aggregators conforming to the type interface Aggregator may receive non-number value on Aggregator.update.

Short description of the changes

• Skip the value update if the value if not typed with number on BaseBoundInstrument.update.

[codecov]

Codecov Report

Merging #1366 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   93.89%   93.80%   -0.10%     
==========================================
  Files         148      144       -4     
  Lines        4393     4276     -117     
  Branches      894      869      -25     
==========================================
- Hits         4125     4011     -114     
+ Misses        268      265       -3     

Impacted Files	Coverage Δ
...kages/opentelemetry-metrics/src/BoundInstrument.ts	100.00% <100.00%> (ø)
...ackages/opentelemetry-exporter-jaeger/src/types.ts
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts
...ackages/opentelemetry-exporter-jaeger/src/utils.ts
...ges/opentelemetry-exporter-jaeger/src/transform.ts

[obecny]

what do you mean by "trunk" here?

[dyladan]

Most likely trunc or truncate. @legendecas Please avoid abbreviations.

[obecny]

ignore then ?

[dyladan]

No, it's a typo and it should be fixed, and the other cases should be made into their own tests.

Suggested change

	it('should trunk non-integer values for INT valueType', async () => {
	it('should truncate floating number values for INT valueType', async () => {

[obecny]

why extra brackets are needed here and in few other places ? If you want to separate cases perhaps it's a moment where it should go into separate unit test or simply make an array of values to test and then use a loop to test each value

[dyladan]

The brackets give lexical scope to the const [record1] = meter.getBatcher().checkPointSet(); line. It is repeated several times in the test so that different values may be tested.

These should be separate tests as they are not all testing truncation

[legendecas]

@dyladan @obecny updated, PTAL :D

[dyladan]

@obecny @vmarchaud looks like your concerns have been addressed?