Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing grpc-js index #1358

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix: add missing grpc-js index #1358

merged 1 commit into from
Jul 28, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 28, 2020

EMERGENCY BUGFIX. grpc-js plugin is broken right now.

@dyladan dyladan added the bug Something isn't working label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #1358 into master will increase coverage by 2.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
+ Coverage   90.89%   93.18%   +2.29%     
==========================================
  Files          61      149      +88     
  Lines        1593     4228    +2635     
  Branches      336      869     +533     
==========================================
+ Hits         1448     3940    +2492     
- Misses        145      288     +143
Impacted Files Coverage Δ
...ackages/opentelemetry-metrics/src/MeterProvider.ts 100.00% <0.00%> (ø)
...ges/opentelemetry-metrics/src/SumObserverMetric.ts 100.00% <0.00%> (ø)
packages/opentelemetry-plugin-https/src/https.ts 100.00% <0.00%> (ø)
...s/opentelemetry-plugin-grpc-js/src/client/index.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-exporter-zipkin/src/types.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-metrics/src/BoundInstrument.ts 100.00% <0.00%> (ø)
...ontext-async-hooks/src/AsyncHooksContextManager.ts 100.00% <0.00%> (ø)
...rces/src/platform/node/detectors/AwsEc2Detector.ts 87.50% <0.00%> (ø)
packages/opentelemetry-tracing/src/utility.ts 100.00% <0.00%> (ø)
...emetry-metrics/src/export/ConsoleMetricExporter.ts 62.50% <0.00%> (ø)
... and 82 more

@dyladan dyladan merged commit 04015a9 into open-telemetry:master Jul 28, 2020
@dyladan dyladan deleted the bugfix-missing-grpc-js-index branch July 28, 2020 12:57
sidharthv96 added a commit to sidharthv96/opentelemetry-js that referenced this pull request Jul 28, 2020
@sidharthv96
Merge remote-tracking branch 'upstream/master' into persist_benchmarks
3fc1ce6 
* upstream/master:
  fix: add missing grpc-js index (open-telemetry#1358)
  chore: 0.10.0 release proposal (open-telemetry#1345)
  Proto update to latest to support arrays and maps (open-telemetry#1339)
  feat: add OTEL_LOG_LEVEL env var (open-telemetry#974)
  Add nodejs sdk package (open-telemetry#1187)
  feat: add baggage support to the opentracing shim (open-telemetry#918)
  Removing default span attributes (open-telemetry#1342)
@reggiemcdonald reggiemcdonald mentioned this pull request Jul 28, 2020
Closed
jonahrosenblum pushed a commit to jonahrosenblum/opentelemetry-js that referenced this pull request Aug 8, 2020
@dyladan @jonahrosenblum
fix: add missing grpc-js index (open-telemetry#1358)
32db1a9
obecny added a commit that referenced this pull request Aug 17, 2020
@jonahrosenblum @dyladan
@obecny @aravinsiva @rubenvp8510 @mayurkale22 @naseemkullah @legendecas @markwolff @mwear @EdZou @reggiemcdonald @renovate-bot @srjames90 @davidwitten @mickdekkers
Add Graceful Shutdown Support (#1321)
b884eec 
* feat: graceful shutdown for tracing and metrics

* fix: wording in test case

* fix: typo

* fix meterprovider config to use bracket notation

Co-authored-by: Daniel Dyla <[email protected]>

* fix meterprovider config to use bracket notation

Co-authored-by: Daniel Dyla <[email protected]>

* fix: add callbacks to shutdown methods

* fix: merge conflict

* simplify meter shutdown code

Co-authored-by: Daniel Dyla <[email protected]>

* fix: fix one-liner

* private function name style fix

Co-authored-by: Daniel Dyla <[email protected]>

* fix: naming of private member variables

* fix: graceful shutdown now works in browser

* fix: window event listener will trigger once

* fix: modify global shutdown helper functions

* fix: remove callback from remove listener args

* fix: change global shutdown function names and simplify functionality

* fix: add rest of function refactoring and simplification

* fix: remove unintended code snippet

* fix: refactor naming of listener cleanup function and fix sandbox issue

* fix: make global shutdown cleanup local

* fix: change interval of MeterProvider collection to ensure it does not trigger through clock

* chore: removing _cleanupGlobalShutdownListeners

* fix: remove unnecesary trace provider member function

* Removing default span attributes (#1342)

* refactor(opentelemetry-tracing): removing default span attributes

Signed-off-by: Aravin Sivakumar <[email protected]>

* refactor(opentelemetry-tracing): removing default span attributed from tracer object

Signed-off-by: Aravin Sivakumar <[email protected]>

* refactor(opentelemetry-tracing): removing accidental add to package.json

Signed-off-by: Aravin Sivakumar <[email protected]>

* refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel

Signed-off-by: Aravin Sivakumar <[email protected]>

* feat: add baggage support to the opentracing shim (#918)

Co-authored-by: Mayur Kale <[email protected]>

* Add nodejs sdk package (#1187)

Co-authored-by: Naseem <[email protected]>
Co-authored-by: legendecas <[email protected]>
Co-authored-by: Mark Wolff <[email protected]>
Co-authored-by: Matthew Wear <[email protected]>

* feat: add OTEL_LOG_LEVEL env var (#974)

* Proto update to latest to support arrays and maps (#1339)

* chore: 0.10.0 release proposal (#1345)

* fix: add missing grpc-js index (#1358)

* chore: 0.10.1 release proposal (#1359)

* feat(api/context-base): change compile target to es5 (#1368)

* Feat: Make ID generator configurable (#1331)

Co-authored-by: Daniel Dyla <[email protected]>

* fix: require grpc-js instead of grpc in grpc-js example (#1364)

Co-authored-by: Bartlomiej Obecny <[email protected]>

* chore(deps): update all non-major dependencies (#1371)

* chore: bump metapackage dependencies (#1383)

* chore: 0.10.2 proposal (#1382)

* fix: remove unnecesary trace provider member function

* refactor(metrics): distinguish different aggregator types (#1325)

Co-authored-by: Daniel Dyla <[email protected]>

* Propagate b3 parentspanid and debug flag (#1346)

* feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320)

Co-authored-by: Daniel Dyla <[email protected]>

* feat: Collector Metric Exporter for the Web (#1308)

Co-authored-by: Daniel Dyla <[email protected]>

* Fix issues in TypeScript getting started example code (#1374)

Co-authored-by: Daniel Dyla <[email protected]>

* chore: deploy canary releases (#1384)

* fix: protos pull

* fix: address marius' feedback

* chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier

* fix: add documentation and cleanup code

* fix: remove async label from shutdown and cleanup test case

* fix: update controller collect to return promise

* fix: make downsides of disabling graceful shutdown more apparent

Co-authored-by: Daniel Dyla <[email protected]>
Co-authored-by: Bartlomiej Obecny <[email protected]>
Co-authored-by: Aravin <[email protected]>
Co-authored-by: Ruben Vargas Palma <[email protected]>
Co-authored-by: Mayur Kale <[email protected]>
Co-authored-by: Naseem <[email protected]>
Co-authored-by: legendecas <[email protected]>
Co-authored-by: Mark Wolff <[email protected]>
Co-authored-by: Matthew Wear <[email protected]>
Co-authored-by: Naseem <[email protected]>
Co-authored-by: Mark Wolff <[email protected]>
Co-authored-by: Cong Zou <[email protected]>
Co-authored-by: Reginald McDonald <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: srjames90 <[email protected]>
Co-authored-by: David W <[email protected]>
Co-authored-by: Mick Dekkers <[email protected]>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@Flarna @renovate-bot
fix(deps): update otel core experimental to ^0.35.1 (open-telemetry#1358
ff109b7 
)

* fix(deps): update otel core experimental to ^0.35.1

* chore: adapt fastify tests to fit http instrumentation

http instrumentation ends server spans later which results in exporting them later.
Adapt the tests to fit the new sequence.

---------

Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naseemkullah naseemkullah naseemkullah approved these changes

@legendecas legendecas legendecas approved these changes

@markwolff markwolff markwolff approved these changes

@obecny obecny obecny approved these changes

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@mwear mwear Awaiting requested review from mwear

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dyladan @obecny @markwolff @legendecas @naseemkullah