Feat: Make ID generator configurable

packages/opentelemetry-core/src/platform/browser/RandomIdGenerator.ts

@@ -13,19 +13,17 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import {IdGenerator} from '../../trace/IdGenerator';
+import { IdGenerator } from '../../trace/IdGenerator';
 
 declare type WindowWithMsCrypto = Window & {
-    msCrypto?: Crypto;
+  msCrypto?: Crypto;
 };
 const cryptoLib = window.crypto || (window as WindowWithMsCrypto).msCrypto;
-
 const SPAN_ID_BYTES = 8;
 const TRACE_ID_BYTES = 16;
 const randomBytesArray = new Uint8Array(TRACE_ID_BYTES);
 
 export class RandomIdGenerator implements IdGenerator {
-
   /**
    * Returns a random 16-byte trace ID formatted/encoded as a 32 lowercase hex
    * characters corresponding to 128 bits.
@@ -53,15 +51,14 @@ export class RandomIdGenerator implements IdGenerator {
     const chars: number[] = new Array(byteArray.length * 2);
     const alpha = 'a'.charCodeAt(0) - 10;
     const digit = '0'.charCodeAt(0);
-  
+
     let p = 0;
     for (let i = 0; i < byteArray.length; i++) {
       let nibble = (byteArray[i] >>> 4) & 0xf;
       chars[p++] = nibble > 9 ? nibble + alpha : nibble + digit;
       nibble = byteArray[i] & 0xf;
       chars[p++] = nibble > 9 ? nibble + alpha : nibble + digit;
     }
-
     return String.fromCharCode.apply(null, chars);
   }
-}
+}

packages/opentelemetry-core/src/platform/node/RandomIdGenerator.ts

@@ -15,13 +15,12 @@
  */
 
 import * as crypto from 'crypto';
-import {IdGenerator} from '../../trace/IdGenerator';
+import { IdGenerator } from '../../trace/IdGenerator';
 
 const SPAN_ID_BYTES = 8;
 const TRACE_ID_BYTES = 16;
 
 export class RandomIdGenerator implements IdGenerator {
-
   /**
    * Returns a random 16-byte trace ID formatted/encoded as a 32 lowercase hex
    * characters corresponding to 128 bits.

packages/opentelemetry-tracing/src/Tracer.ts

@@ -39,10 +39,10 @@ export class Tracer implements api.Tracer {
   private readonly _defaultAttributes: api.Attributes;
   private readonly _sampler: api.Sampler;
   private readonly _traceParams: TraceParams;
+  private readonly _idGenerator: IdGenerator;
   readonly resource: Resource;
   readonly instrumentationLibrary: InstrumentationLibrary;
   readonly logger: api.Logger;
-  readonly idGenerator: IdGenerator;
 
   /**
    * Constructs a new Tracer instance.
@@ -56,10 +56,10 @@ export class Tracer implements api.Tracer {
     this._defaultAttributes = localConfig.defaultAttributes;
     this._sampler = localConfig.sampler;
     this._traceParams = localConfig.traceParams;
+    this._idGenerator = config.idGenerator || new RandomIdGenerator();
     this.resource = _tracerProvider.resource;
     this.instrumentationLibrary = instrumentationLibrary;
     this.logger = config.logger || new ConsoleLogger(config.logLevel);
-    this.idGenerator = config.idGenerator || new RandomIdGenerator();
   }
 
   /**
@@ -72,12 +72,12 @@ export class Tracer implements api.Tracer {
     context = api.context.active()
   ): api.Span {
     const parentContext = getParent(options, context);
-    const spanId = this.idGenerator.generateSpanId();
+    const spanId = this._idGenerator.generateSpanId();
     let traceId;
     let traceState;
     if (!parentContext || !isValid(parentContext)) {
       // New root span.
-      traceId = this.idGenerator.generateTraceId();
+      traceId = this._idGenerator.generateTraceId();
     } else {
       // New child span.
       traceId = parentContext.traceId;

packages/opentelemetry-tracing/src/types.ts

@@ -54,7 +54,7 @@ export interface TracerConfig {
   resource?: Resource;
 
   /**
-   * Generator of trace and span IDs 
+   * Generator of trace and span IDs
    * The prototype IdGenerator generates random 16-byte trace ID and 8-byte span ID
    */
   idGenerator?: IdGenerator;