Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency nock to v13 #1298

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency nock to v13 #1298

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
nock devDependencies major 12.0.3 -> 13.0.2

Release Notes

nock/nock

v13.0.2

Compare Source

Bug Fixes

v13.0.1

Compare Source

Bug Fixes

v13.0.0

Compare Source

See the Migration Guide

Breaking changes
  1. Scope.log has been removed. Use the debug library when debugging failed matches.

  2. socketDelay has been removed. Use delayConnection instead.

  3. delay, delayConnection, and delayBody are now setters instead of additive.

  4. When recording, skipping body matching using * is no longer supported by nock.define.
    Set the definition body to undefined instead.

  5. ClientRequest.abort() has been updated to align with Node's native behavior.
    This could be considered a feature, however, it created some subtle differences that are not backwards compatible. Refer to the migration guide for details.

  6. Playback of a mocked responses will now never happen until the 'socket' event is emitted.


Renovate configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@obecny
Copy link
Member

obecny commented Jul 10, 2020

it looks like socketDelay has been removed from nock in favour of delayConnection so the upgrade to v13 is not possible without changing the code (although not sure if this is the only change) @mayurkale22 what do you usually do in such situation ?

@mayurkale22
Copy link
Member

it looks like socketDelay has been removed from nock in favour of delayConnection so the upgrade to v13 is not possible without changing the code (although not sure if this is the only change) @mayurkale22 what do you usually do in such situation ?

In case of devdependencies, I just close the PR. Ideally, we should open an issue and close the PR to address it later.

@obecny
Copy link
Member

obecny commented Jul 10, 2020

closing and opening a new issue to make it manually
#1303

@obecny obecny closed this Jul 10, 2020
@forking-renovate
Copy link

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 13.x releases. However, if you upgrade to 13.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate-bot renovate-bot deleted the renovate/nock-13.x branch July 10, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants