feat: adding json over http for collector exporter #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
obecny
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
+ Coverage 92.86% 93.08% +0.21%
==========================================
Files 130 133 +3
Lines 3546 3759 +213
Branches 728 760 +32
==========================================
+ Hits 3293 3499 +206
- Misses 253 260 +7
|
vmarchaud
approved these changes
Jun 26, 2020
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporter.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporter.ts
Outdated
Show resolved
Hide resolved
mwear
approved these changes
Jun 26, 2020
packages/opentelemetry-exporter-collector/src/platform/browser/CollectorExporter.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporter.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporter.ts
Outdated
Show resolved
Hide resolved
mwear
approved these changes
Jun 26, 2020
|
@open-telemetry/javascript-maintainers ^^ |
naseemkullah
approved these changes
Jul 2, 2020
mayurkale22
approved these changes
Jul 2, 2020
| const exporter = new CollectorTraceExporter({ | ||
| serviceName: 'basic-service', | ||
| url: address, | ||
| // headers: { |
There was a problem hiding this comment.
Why this is commented out? Custom headers and metadata feature released in 0.9.0.
There was a problem hiding this comment.
this is an example to be able to test it or not
packages/opentelemetry-exporter-collector/src/platform/node/CollectorTraceExporter.ts
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/utilWithJson.ts
Show resolved
Hide resolved
dyladan
approved these changes
Jul 2, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes