-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Test Coverage for XML Http Plugin #1216
Increase Test Coverage for XML Http Plugin #1216
Conversation
Signed-off-by: Tina Gao <[email protected]>
added test for when request url is an ignored url from plugin config
fix header propagation tests that were affected by added a preflight span
Added tests for clearTimingResources setting in the plugin's config for the default behaviour when unspecified (false) and for explicitly setting to true.
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
+ Coverage 92.32% 93.20% +0.87%
==========================================
Files 122 122
Lines 3533 3533
Branches 714 714
==========================================
+ Hits 3262 3293 +31
+ Misses 271 240 -31
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, thanks for working on this.
@open-telemetry/javascript-approvers Please take a look when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage is something that gets left behind too often. Nice to have some improvements here.
Which problem is this PR solving?
Short description of the changes