chore: creating new metric kind #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Closed
mayurkale22
reviewed
Jun 4, 2020
mayurkale22
approved these changes
Jun 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
=======================================
Coverage 92.30% 92.31%
=======================================
Files 116 116
Lines 3393 3397 +4
Branches 685 685
=======================================
+ Hits 3132 3136 +4
Misses 261 261
|
markwolff
approved these changes
Jun 4, 2020
vmarchaud
approved these changes
Jun 5, 2020
mwear
approved these changes
Jun 5, 2020
naseemkullah
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
this can be done later when PR for new metris will be merged
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/api.md#interpretation