-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename meaure to value recorder #1117
chore: rename meaure to value recorder #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick question on a first pass, was there any documentation or examples that needs to be updated as well ?
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 116 116
Lines 3396 3396
Branches 686 686
=======================================
Hits 3134 3134
Misses 262 262
|
I'm sure there is, but this touches enough places that I am going to do it as separate PRs so it isn't overwhelming to review. @mayurkale22 that ok? |
https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-metrics#measure I think this is the only place we have a reference for |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@dyladan Looks like this is good to merge now. |
Fixes #1112